Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mixpanel incremental properties): add check for undefined properties #2634

Merged
merged 1 commit into from
Sep 20, 2023
Merged

fix(mixpanel incremental properties): add check for undefined properties #2634

merged 1 commit into from
Sep 20, 2023
+8 −6

Conversation

Gauravudia
Copy link
Contributor

@Gauravudia Gauravudia commented Sep 20, 2023 •
edited
Loading

Description of the change

Add null/undefined safety check for properties.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@Gauravudia Gauravudia requested a review from a team as a code owner September 20, 2023 08:59
@Gauravudia Gauravudia self-assigned this Sep 20, 2023
@Gauravudia Gauravudia requested review from saikumarrs and removed request for a team September 20, 2023 08:59
@Gauravudia Gauravudia requested review from ItsSudip and removed request for saikumarrs September 20, 2023 09:02
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (22dc7b8) 86.89% compared to head (a7a925b) 86.89%.

Additional details and impacted files 
@@               Coverage Diff                @@
##           release/v1.42.0    #2634   +/-   ##
================================================
  Coverage            86.89%   86.89%           
================================================
  Files                  603      603           
  Lines                28140    28141    +1     
  Branches              6697     6698    +1     
================================================
+ Hits                 24451    24452    +1     
  Misses                3356     3356           
  Partials               333      333
Files Changed Coverage Δ
src/v0/destinations/mp/transform.js 97.37% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

68.5% 68.5% Coverage
0.0% 0.0% Duplication

@Gauravudia Gauravudia merged commit f267aa3 into release/v1.42.0 Sep 20, 2023
@Gauravudia Gauravudia deleted the fix/mixpanel-incremental-properties branch December 14, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ujjwal-ab ujjwal-ab ujjwal-ab approved these changes

@ItsSudip ItsSudip Awaiting requested review from ItsSudip

Assignees

@Gauravudia Gauravudia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gauravudia @ujjwal-ab